I didn't test it, just a suggestion:
{% set base_uboot_kernel_commands = base_uboot_kernel_commands|default(["tftp {KERNEL_ADDR} {KERNEL}"]) %} {% set base_uboot_ramdisk_commands = base_uboot_kernel_commands|default(["tftp {RAMDISK_ADDR} {RAMDISK}"]) %}
{% if RAMDISK is defined %} {% set base_uboot_tftp_commands = uboot_tftp_commands|default(base_uboot_kernel_commands + base_uboot_ramdisk_commands + ["setenv initrd_size ${filesize}"] + uboot_load_fdt) -%} {% else %} {% set base_uboot_tftp_commands = uboot_tftp_commands|default(base_uboot_kernel_commands + ["setenv initrd_size ${filesize}"] + uboot_load_fdt) -%} {% endif %}
milosz
On Tue, 12 Nov 2019 at 13:17, Remi Duraffort remi.duraffort@linaro.org wrote:
See https://git.lavasoftware.org/lava/lava/blob/master/etc/dispatcher-config/dev...
Le mar. 12 nov. 2019 à 14:17, Remi Duraffort remi.duraffort@linaro.org a écrit :
Yes but it's difficult to know which line to remove as we only have a list of commands to send. Without any metadata.
Le mar. 12 nov. 2019 à 14:15, Milosz Wasilewski milosz.wasilewski@linaro.org a écrit :
On Tue, 12 Nov 2019 at 13:13, Remi Duraffort remi.duraffort@linaro.org wrote:
Hello,
I created a merge request for a similar issue to lony send the commands that are actually used. But in order to fix that properly, I have to create another set of u-boot commands to support ramdisk and another one for ramdisk-nfs.
See https://git.lavasoftware.org/lava/lava/merge_requests/492
In order to merge this MR we need a migration path to keep compatibility with jobs that uses the ability to use both ramdisk and nfs at the same time.
Wouldn't it be better to simply omit the ramdisk related line from u-boot commands when ramdisk is not defined in the job?
milosz
Rgds
Le lun. 11 nov. 2019 à 13:02, Diego Russo Diego.Russo@arm.com a écrit :
> What's the best way to solve the issue. How can I tell LAVA not to deal with the RAMDISK at all? I saw this problem on some other board (don't remember which one). The quick fix is to replace the bootloader commands with custom ones either in device dictionary or in the job. In the long run this needs to be fixed in LAVA. I'll create a ticket if there isn't one already. For updating the commands in the job, here is the snippet: - boot: timeout: minutes: 10 method: u-boot commands: - setenv autoload no - dhcp - env print - setenv serverip {SERVER_IP} - tftp {KERNEL_ADDR} {KERNEL} - tftp {DTB_ADDR} {DTB} - setenv bootargs 'console=ttyS0,115200n8 root=/dev/nfs rw nfsroot={NFS_SERVER_IP}:{NFSROOTFS},tcp,hard,intr,vers=3 rootwait coherent_pool=2M ip=dhcp' - '{BOOTX}' This should do the trick for now. miloszMilosz,
I've come up with a similar solution. I've added the following lines into the device type of the board:
{% set uboot_tftp_commands = [ "tftp {KERNEL_ADDR} {KERNEL}", "tftp {DTB_ADDR} {DTB}"] -%}
Thanks
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ Lava-users mailing list Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users
-- Rémi Duraffort LAVA Architect Linaro
-- Rémi Duraffort LAVA Architect Linaro
-- Rémi Duraffort LAVA Architect Linaro