On 30/03/2023 17:05, Teo Couprie Diaz wrote:
On 30/03/2023 15:43, Kevin Brodsky wrote:
On 30/03/2023 16:35, Teo Couprie Diaz wrote:
+In order for the skip files to successfully filter-out expected/known failures in AArch64, +morello-release-1.6.0 release, or newer is required.
I think that one might be confusing because it's unclear which component that requirement applies to, especially since the files we're adding require release 1.5 for the kernel and Musl, not 1.6.
Mh I'm not sure I understand correctly. There are multiple tests that require either Musl or Linux 1.6 (or, at any rate, newer than 1.5) to run successfully. The files themselves don't really need anything, for sure, but for the test suite to pass it would.
But I agree that my phrasing is unclear, slightly voluntarily. Indeed it would be correct only in compat, as you confirmed that the io_uring changes wouldn't make it in the 1.6 release, and so in purecap io_uring01 will fail even with the skip list until the following release.
I wanted to set some kind of expectation with regards to versions and expected success. Maybe it's not needed ? Maybe being more explicit would be needed now that we know precisely which tests would or wouldn't be fixed compared to 1.5 ?
Right, I do understand that some tests that we don't mention anywhere will be failing on 1.5. I don't think we need to be more specific, we are likely to get it wrong without much benefit. I guess what I don't understand at this point is what the KERN and MUSL comments in the skip files mean, as they mention 1.5. Or is it that they say "strictly greater" (> 1.5) and therefore 1.6 or above? If so I would just say ">= 1.6" which is much less likely to be misinterpreted.
Oh, yes that was I was meaning to convey. Will update with ">= 1.6" then. Should I simply remove the mention in the README then ?
Sounds good. It doesn't hurt to keep this paragraph in the README, the comments in the skip files are easily missed. While at it, might be good to clarify it as right now it talks about successfully filtering out, which is going to happen in any case :) Maybe say something along the lines that the skip files are only comprehensive for release 1.6 and above?
Kevin