+ Beata
On 04/04/2023 12:22, Tudor Cretu wrote:
AFAICT __pad2 also needs to be expanded. In fact I'm surprised that these changes work in PCuABI as they stand, because with __pad2 unchanged I would expect the struct to be 16 bytes smaller than the uapi definition. Maybe I'm missing something?
Good catch!
This struct is not actually used. The uAPI header is used if it exists, here (lines 21-25):
https://git.morello-project.org/tudcre01/morello-linux-ltp/-/blob/81111e0f44...
Right I understand now! But then maybe we shouldn't bother updating these definitions? Do other tests actually build fine in purecap without uapi headers? If we modify these fallbacks we may want to test them too, but I'm not sure it's worth it.
I'm starting to wonder if it's not the same situation for struct clone_args, which we modified but might not be actually using?
Kevin