15 Nov
2023
15 Nov
'23
9:15 p.m.
On 14/11/2023 20:22, Kevin Brodsky wrote:
+/*
- As the size of the struct has changed with the use of __kernel_uintptr_t,
"changed in PCuABI", to be specific.
- it is necessary to hard-code the size of the compat64 struct so that the
"compat64" is very specific, but in fact this size is the same in any ABI except PCuABI.
- correct ioctl number is assigned. This also applies to MMC_IOC_MULTI_CMD.
I think it might be good to say explicitly that the goal is for the value to remain unchanged - one could argue which value is the "correct" one in PCuABI.
Forgot to say: it would also be nice to keep the original _IOWR definition (that refers to struct mmc_ioc_cmd) in the comment, just to make it clear what 72 corresponds to exactly.
Kevin
- */
+#define MMC_IOC_CMD _IOC(_IOC_READ|_IOC_WRITE, MMC_BLOCK_MAJOR, 0, 72) /*