Hi Kevin,
On 7/12/23 11:39, Kevin Brodsky wrote:
Nice patch! It's a clear improvement to that Makefile, regardless of our specific Morello interests, which means it should be welcome upstream.
Thank you for the kind feedback!
Just a suggestion, since you've started doing some cleanup in that Makefile to use lib.mk functionalities: I think you should be able to remove this rule, as lib.mk already includes it.
Kevin
$(OUTPUT)/vdso_test_gettimeofday: parse_vdso.c vdso_test_gettimeofday.c $(OUTPUT)/vdso_test_getcpu: parse_vdso.c vdso_test_getcpu.c
Apologies, I'm not quite 100% sure what you mean here. From what I understand, we'd still need these lines due to the dependency on parse_vdso.c for each test binary. I tried removing those lines and the Makefile didn't work. Please let me know if I've missed something. However, as we explicitly state recipes, we can remove the $(TEST_GEN_PROGS) after the all target like so:
-all: $(TEST_GEN_PROGS) +all:
If you agree with this approach, please let me know and I'll amend the patch.
Thanks, Aditya