[linux-morello] Re: [PATCH v2 6/7] net/br_ioctl: Support 64-bit pointers in compat

Nit: in commit title, "net: bridge:" seems to be the most common tag for this file (same for the previous patch).

Kevin

On 02/02/2023 17:50, Luca Vizzarro wrote:

The br_dev_read_uargs function copies a list of arguments from a user capability. When operating in compat64, pointers are 64-bit long and cannot be represented as unsigned int. In this scenario the function copies a list of compat pointers, therefore the type of the receiver variable, cargs, must be updated to compat_uptr_t from unsigned int.

Signed-off-by: Luca Vizzarro Luca.Vizzarro@arm.com

net/bridge/br_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_ioctl.c b/net/bridge/br_ioctl.c index aa4e34cf8754..439a5e5d7b5d 100644 --- a/net/bridge/br_ioctl.c +++ b/net/bridge/br_ioctl.c @@ -117,7 +117,7 @@ static int br_dev_read_uargs(user_uintptr_t *args, size_t nr_args, return -EINVAL; if (in_compat_syscall()) {

• unsigned int cargs[BR_UARGS_MAX];
  

• compat_uptr_t cargs[BR_UARGS_MAX];
  

  int i;

ret = copy_from_user(cargs, data, nr_args * sizeof(*cargs));