Hi Tudor,
On 17/10/2022 18:29, Tudor Cretu wrote:
Hi Teo,
On 17-10-2022 17:55, Teo Couprie Diaz wrote:
Co-authored-by: Tudor Cretu tudor.cretu@arm.com
For future references, the correct tag is: Co-Developed-by.
Interesting, I didn't come across it before and grepping the git log did confirm that "Co-authored" was used at a least a few times. Will keep that in mind !
I appreciate adding me! In this case, I think it's more appropriate if you remove my name as it's your idea and your testing whereas I merely suggested an alternative, so no need to credit me for it 😉.
I'll trust your judgment then !
Signed-off-by: Teo Couprie Diaz teo.coupriediaz@arm.com
Thanks Tudor for providing the code snippet, making it much more clear than my original ideas.
My pleasure, good job for the patches!
mm/mmap.c | 5 +++++ Â 1 file changed, 5 insertions(+)
diff --git a/mm/mmap.c b/mm/mmap.c index ce282f9d9f8e..1048c358b872 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -194,6 +194,11 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long          struct list_head *uf);  SYSCALL_DEFINE1(brk, unsigned long, brk)  { +#ifdef CONFIG_CHERI_PURECAP_UABI + if (!in_compat_syscall()) { +   return -ENOSYS; + } +#endif
The code looks good to me. There are a few formatting nits, use tabs instead of spaces. Make sure to set your tab width to 8 spaces to check if everything aligns nicely as you expected. Also, no need for braces for single-statement blocks. Make sure to use checkpatch if it complains about anything else.
Checkpatch complains about using -ENOSYS but that's to be expected, as we want it to act as if brk was not implemented and that seems to be valid.
Thanks, Tudor
Thanks for the review Tudor, mainly it's me not paying attention. I'll probably add a git hook to run checkpatch on commit to try and limit that. Téo