Stratos-dev December 2022

stratos-dev@op-lists.linaro.org

5 participants
5 discussions

[PATCH] libxl: virtio: Fix build error for 32-bit platforms

by Viresh Kumar

The field 'base' in 'struct libxl_device_virtio' is defined as uint64, while we are printing it with '%lu', which is 32bit only 32-bit platforms. And so generates a error like: libxl_internal.h:4388:51: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=] Fix the same by using PRIx64 instead. Now that the base name is available in hexadecimal format, prefix it with '0x' as well, which strtoul() also depends upon since base passed is 0. Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device") Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- Couldn't test on 32-bit platforms yet, but works fine for 64 bit one. tools/libs/light/libxl_virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_virtio.c b/tools/libs/light/libxl_virtio.c index 6a38def2faf5..2217bda8a253 100644 --- a/tools/libs/light/libxl_virtio.c +++ b/tools/libs/light/libxl_virtio.c @@ -45,12 +45,12 @@ static int libxl__set_xenstore_virtio(libxl__gc *gc, uint32_t domid, const char *transport = libxl_virtio_transport_to_string(virtio->transport); flexarray_append_pair(back, "irq", GCSPRINTF("%u", virtio->irq)); - flexarray_append_pair(back, "base", GCSPRINTF("%lu", virtio->base)); + flexarray_append_pair(back, "base", GCSPRINTF("0x%"PRIx64, virtio->base)); flexarray_append_pair(back, "type", GCSPRINTF("%s", virtio->type)); flexarray_append_pair(back, "transport", GCSPRINTF("%s", transport)); flexarray_append_pair(front, "irq", GCSPRINTF("%u", virtio->irq)); - flexarray_append_pair(front, "base", GCSPRINTF("%lu", virtio->base)); + flexarray_append_pair(front, "base", GCSPRINTF("0x%"PRIx64, virtio->base)); flexarray_append_pair(front, "type", GCSPRINTF("%s", virtio->type)); flexarray_append_pair(front, "transport", GCSPRINTF("%s", transport)); -- 2.31.1.272.g89b43f80a514

1 year, 10 months

[PATCH V10 0/3] toolstack support for generic virtio devices on Arm

by Viresh Kumar

Hello, This patchset adds toolstack support for I2C, GPIO and generic virtio devices. This is inspired from the work done by Oleksandr for the Disk device. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backends [1]. This is based of Xen's master branch. V9->V10: - Swap I2C/GPIO compatible strings, they were wrongly added earlier. - Arrange tags in timely order and add new ones. V8->V9: - Drop changes to tools/ocaml/libs/xl/genwrap.py file. - Replace GPIO with I2C in a comment. - Add Reviewed-by tags. V7->V8: - Use macros for compatible string names. - Use strcmp() instead of strncmp() at several places. - Rename "virtio,devices" to "virtio,device" in commit log. - Remove extra call to fdt_end_node(). - Disallow "unknown" in xenstore transport. - Use libxl__strdup(). - Update documentation. - Remove DEVICE_ADDREMOVE(virtio). V6->V7: - Support generic virtio devices too. They are passed with type=virtio,device, and we only create the MMIO DT node for them. - Add links to DT bindings of I2C and GPIO, in code and documentation. - Call libxl__device_add() for all hypervisor types. - Add (0, "UNKNOWN") for libxl_virtio_transport. - Removed libxl_virtio_backend and libxl_virtioinfo, as they were unused. - Remove unnecessary stuff from libxl__virtio_from_xenstore() and add support for type and transport. - Add backend=domid in documentation and replace compatible with type. - Improved commit logs. V5->V6: - The cleanup patches are sent separately [2]. - We don't add I2C or GPIO specific device changes anymore, rather we create generic "virtio" devices. The "type" of a virtio devices helps us identify the right device, and create an entry in the DT node. The same can be used for all Virtio devices now. - Update man page xl.cfg. V4->V5: - Fixed indentation at few places. - Removed/added blank lines. - Added few comments. - Added review tags from Oleksandr. - Rebased over latest staging branch. V3->V4: - Update virtio_enabled independently of all devices, so we don't miss setting it to true. - Add iommu handling for i2c/gpio and move it as part of make_virtio_mmio_node_common(), which gets backend_domid parameter as a result. V2->V3: - Rebased over latest tree and made changes according to changes in Oleksandr's patches from sometime back. - Minor cleanups. V1->V2: - Patches 3/6 and 4/6 are new. - Patches 5/6 and 6/6 updated based on the above two patches. - Added link to the bindings for I2C and GPIO. - Rebased over latest master branch. Thanks. -- Viresh [1] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i… Viresh Kumar (3): libxl: Add support for generic virtio device xl: Add support to parse generic virtio device docs: Add documentation for generic virtio devices docs/man/xl.cfg.5.pod.in | 33 +++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 100 +++++++++++++++ tools/libs/light/libxl_create.c | 4 + tools/libs/light/libxl_internal.h | 6 + tools/libs/light/libxl_types.idl | 18 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_virtio.c | 144 ++++++++++++++++++++++ tools/xl/xl_parse.c | 81 ++++++++++++ 9 files changed, 388 insertions(+) create mode 100644 tools/libs/light/libxl_virtio.c -- 2.31.1.272.g89b43f80a514

1 year, 11 months

[PATCH V9 0/3] toolstack support for generic virtio devices on Arm

by Viresh Kumar

Hello, This patchset adds toolstack support for I2C, GPIO and generic virtio devices. This is inspired from the work done by Oleksandr for the Disk device. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backends [1]. This is based of Xen's master branch. V8->V9: - Drop changes to tools/ocaml/libs/xl/genwrap.py file. - Replace GPIO with I2C in a comment. - Add Reviewed-by tags. V7->V8: - Use macros for compatible string names. - Use strcmp() instead of strncmp() at several places. - Rename "virtio,devices" to "virtio,device" in commit log. - Remove extra call to fdt_end_node(). - Disallow "unknown" in xenstore transport. - Use libxl__strdup(). - Update documentation. - Remove DEVICE_ADDREMOVE(virtio). V6->V7: - Support generic virtio devices too. They are passed with type=virtio,device, and we only create the MMIO DT node for them. - Add links to DT bindings of I2C and GPIO, in code and documentation. - Call libxl__device_add() for all hypervisor types. - Add (0, "UNKNOWN") for libxl_virtio_transport. - Removed libxl_virtio_backend and libxl_virtioinfo, as they were unused. - Remove unnecessary stuff from libxl__virtio_from_xenstore() and add support for type and transport. - Add backend=domid in documentation and replace compatible with type. - Improved commit logs. V5->V6: - The cleanup patches are sent separately [2]. - We don't add I2C or GPIO specific device changes anymore, rather we create generic "virtio" devices. The "type" of a virtio devices helps us identify the right device, and create an entry in the DT node. The same can be used for all Virtio devices now. - Update man page xl.cfg. V4->V5: - Fixed indentation at few places. - Removed/added blank lines. - Added few comments. - Added review tags from Oleksandr. - Rebased over latest staging branch. V3->V4: - Update virtio_enabled independently of all devices, so we don't miss setting it to true. - Add iommu handling for i2c/gpio and move it as part of make_virtio_mmio_node_common(), which gets backend_domid parameter as a result. V2->V3: - Rebased over latest tree and made changes according to changes in Oleksandr's patches from sometime back. - Minor cleanups. V1->V2: - Patches 3/6 and 4/6 are new. - Patches 5/6 and 6/6 updated based on the above two patches. - Added link to the bindings for I2C and GPIO. - Rebased over latest master branch. Thanks. -- Viresh [1] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i… Viresh Kumar (3): libxl: Add support for generic virtio device xl: Add support to parse generic virtio device docs: Add documentation for generic virtio devices docs/man/xl.cfg.5.pod.in | 33 +++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 100 +++++++++++++++ tools/libs/light/libxl_create.c | 4 + tools/libs/light/libxl_internal.h | 6 + tools/libs/light/libxl_types.idl | 18 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_virtio.c | 144 ++++++++++++++++++++++ tools/xl/xl_parse.c | 81 ++++++++++++ 9 files changed, 388 insertions(+) create mode 100644 tools/libs/light/libxl_virtio.c -- 2.31.1.272.g89b43f80a514

1 year, 11 months

[PATCH V7 0/3] toolstack support for generic virtio devices on Arm

by Viresh Kumar

Hello, This patchset adds toolstack support for I2C, GPIO and generic virtio devices. This is inspired from the work done by Oleksandr for the Disk device. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backends [1]. This is based of Julien's for-next/4.18 branch [2]. V6->V7: - Support generic virtio devices too. They are passed with type=virtio,device, and we only create the MMIO DT node for them. - Add links to DT bindings of I2C and GPIO, in code and documentation. - Call libxl__device_add() for all hypervisor types. - Add (0, "UNKNOWN") for libxl_virtio_transport. - Removed libxl_virtio_backend and libxl_virtioinfo, as they were unused. - Remove unnecessary stuff from libxl__virtio_from_xenstore() and add support for type and transport. - Add backend=domid in documentation and replace compatible with type. - Improved commit logs. V5->V6: - The cleanup patches are sent separately [2]. - We don't add I2C or GPIO specific device changes anymore, rather we create generic "virtio" devices. The "type" of a virtio devices helps us identify the right device, and create an entry in the DT node. The same can be used for all Virtio devices now. - Update man page xl.cfg. V4->V5: - Fixed indentation at few places. - Removed/added blank lines. - Added few comments. - Added review tags from Oleksandr. - Rebased over latest staging branch. V3->V4: - Update virtio_enabled independently of all devices, so we don't miss setting it to true. - Add iommu handling for i2c/gpio and move it as part of make_virtio_mmio_node_common(), which gets backend_domid parameter as a result. V2->V3: - Rebased over latest tree and made changes according to changes in Oleksandr's patches from sometime back. - Minor cleanups. V1->V2: - Patches 3/6 and 4/6 are new. - Patches 5/6 and 6/6 updated based on the above two patches. - Added link to the bindings for I2C and GPIO. - Rebased over latest master branch. Thanks. -- Viresh [1] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i… [2] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlo… Viresh Kumar (3): libxl: Add support for generic virtio device xl: Add support to parse generic virtio device docs: Add documentation for generic virtio devices docs/man/xl.cfg.5.pod.in | 28 +++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 103 ++++++++++++++++ tools/libs/light/libxl_create.c | 4 + tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 18 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_virtio.c | 144 ++++++++++++++++++++++ tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/xl_parse.c | 80 ++++++++++++ 11 files changed, 382 insertions(+) create mode 100644 tools/libs/light/libxl_virtio.c -- 2.31.1.272.g89b43f80a514

1 year, 11 months

[PATCH V6 0/3] Virtio toolstack support for I2C and GPIO on Arm

by Viresh Kumar

Hello, This patchset adds toolstack support for I2C and GPIO virtio devices. This is inspired from the work done by Oleksandr for the Disk device. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backend [1]. This is based of origin/staging (e61a78981364 xen/arm: add iounmap after initrd has been loaded in domain_build) and the earlier posted cleanup patches [2]. V5->V6: - The cleanup patches are sent separately [2]. - We don't add I2C or GPIO specific device changes anymore, rather we create generic "virtio" devices. The "type" of a virtio devices helps us identify the right device, and create an entry in the DT node. The same can be used for all Virtio devices now. - Update man page xl.cfg. V4->V5: - Fixed indentation at few places. - Removed/added blank lines. - Added few comments. - Added review tags from Oleksandr. - Rebased over latest staging branch. V3->V4: - Update virtio_enabled independently of all devices, so we don't miss setting it to true. - Add iommu handling for i2c/gpio and move it as part of make_virtio_mmio_node_common(), which gets backend_domid parameter as a result. V2->V3: - Rebased over latest tree and made changes according to changes in Oleksandr's patches from sometime back. - Minor cleanups. V1->V2: - Patches 3/6 and 4/6 are new. - Patches 5/6 and 6/6 updated based on the above two patches. - Added link to the bindings for I2C and GPIO. - Rebased over latest master branch. Thanks. -- Viresh [1] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i… [2] https://lore.kernel.org/all/cover.1662626550.git.viresh.kumar@linaro.org/ Viresh Kumar (3): libxl: Add support for generic virtio device xl: Add support to parse generic virtio device docs: Add documentation for generic virtio devices docs/man/xl.cfg.5.pod.in | 21 ++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 89 +++++++++++++++ tools/libs/light/libxl_create.c | 5 + tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 29 +++++ tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_virtio.c | 127 ++++++++++++++++++++++ tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/xl_parse.c | 84 ++++++++++++++ 11 files changed, 360 insertions(+) create mode 100644 tools/libs/light/libxl_virtio.c -- 2.31.1.272.g89b43f80a514

1 year, 11 months

2024

2023

2022

2021

2020

Stratos-dev December 2022