[Stratos-dev] Re: [libgpiod][PATCH V9 0/8] libgpiod: Add Rust bindings

On Mon, Nov 14, 2022 at 10:49:36PM +0100, Bartosz Golaszewski wrote:

On Mon, Nov 7, 2022 at 10:57 AM Viresh Kumar viresh.kumar@linaro.org wrote:

...

Hello,

Here is another version of the rust bindings, based of the master branch.

Pushed here:

https://github.com/vireshk/libgpiod v9

V8->V9:

• Merged the last patch (supporting Events) with the other patches.
• Events implementation is simplified and made efficient. nth() is also implemented for the iterator.
• Unnecessary comment removed from Cargo.toml files.
• Updated categories in libgpiod's Cargo.toml.
• Updated gpio_events example to show cloned events live past another read_edge_events().
• Implement AsRawFd for Chip.
• Other minor changes.

Kent, Miguel: if you are ok with this version - can you add your review tags?

Bart

As mentioned elsewhere, I'm a bit iffy about the handling of non-UTF-8 names, which are treated as errors, but are valid in the C API. But that is an extreme corner case that can be addressed later, so I have no objection to this version being merged.

Reviewed-by: Kent Gibson warthog618@gmail.com

Cheers, Kent.