On 2021/10/12 19:23, Viresh Kumar wrote:
Hi,
Arnd suggested (over IRC) to split this into two patches for better readability and so here is a resend. The eventual specification hasn't changed at all.
V4->V5:
- Split into two patches.
V3->V4:
- Add a new mandatory feature flag.
V2->V3:
- Add conformance clauses that require that the flag is consistent with the buffer.
V1->V2:
- Name the buffer-less request as zero-length request.
I did try to follow the discussion you guys had during V4, where we added support for multiple buffers for the same request, which I think is unnecessary now, after introduction of the VIRTIO_I2C_FLAGS_FAIL_NEXT flag.
https://lists.oasis-open.org/archives/virtio-comment/202011/msg00005.html
And so starting this discussion again, because we need to support stuff like: i2cdetect -q <i2c-bus-number>, which issues a zero-length SMBus Quick command.
Viresh Kumar (2): virtio: i2c: No need to have separate read-write buffers virtio: i2c: Allow zero-length transactions
LGTM. Thanks Viresh.
Reviewed-by: Jie Deng jie.deng@intel.com