- linux-morello - op-lists.linaro.org

[PATCH v4 0/3] kselftest: Gcc fixes for clone test

by Amit Daniel Kachhap

Hi, These 3 patch fixes the failure in clone test with Gcc toolchain. They need the recent v4 version of Gcc support patches posted earlier [1]. The full patch series can be found here [2]. Changes in v4: * Removed struct test_fixture.result field as suggested by Kevin. * Commit log updated. [1]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_support_v4 [2]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_clone_fixes_v4 Thanks, Amit Daniel Amit Daniel Kachhap (3): kselftests/arm64: morello: Fix restricted mode tests with Gcc kselftests/arm64: morello: Add a waitpid() syscall kselftests/arm64: morello: clone: Remove loop check tools/testing/selftests/arm64/morello/clone.c | 57 ++++++++++--------- .../selftests/arm64/morello/freestanding.h | 12 ++++ .../testing/selftests/arm64/morello/signal.c | 12 ++-- 3 files changed, 48 insertions(+), 33 deletions(-) -- 2.25.1

2 years, 7 months

2
6
0 0

[PATCH v4 00/10] Update in kselftests for Gcc

by Amit Daniel Kachhap

Hi All, This series are modifications in kselftests required to compile with alpha version of Morello Gnu toochain recently released [1]. The whole series can also be found here [2]. Changes in v4 as reviewed by Kevin: * Patch 5 modified for indentation. * Patch 9 modified for cleaning up extra header. * Patch 10 modified to shrink the extra code. Thanks, Amit Daniel [1]: https://developer.arm.com/downloads/-/arm-gnu-toolchain-for-morello-downloa… [2]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_support_v4 Amit Daniel Kachhap (10): kselftests/arm64: morello: Fix inline assembly syntax kselftests/arm64: morello: Define uintcap_t for GCC kselftests/arm64: morello: Fix the -Wcast-function-type warnings kselftests/arm64: morello: Fix the fallthrough warning kselftests/arm64: morello: Avoid limits.h for Gcc kselftests/arm64: morello: clone: Initialize the local variable kselftests/arm64: morello: clone: Guard if clause to avoid warning kselftests/arm64: morello: Process the dynamic relocations kselftests/arm64: morello: Add optimized routine for memcpy kselftests/arm64: morello: Enable Gcc toolchain support .../testing/selftests/arm64/morello/Makefile | 19 +- .../selftests/arm64/morello/bootstrap.c | 7 +- tools/testing/selftests/arm64/morello/clone.c | 6 +- .../selftests/arm64/morello/freestanding.h | 7 + .../arm64/morello/freestanding_init_globals.c | 133 ++++- .../arm64/morello/freestanding_start.S | 5 +- .../selftests/arm64/morello/morello_memcpy.S | 530 ++++++++++++++++++ .../testing/selftests/arm64/morello/signal.c | 4 +- 8 files changed, 689 insertions(+), 22 deletions(-) create mode 100644 tools/testing/selftests/arm64/morello/morello_memcpy.S -- 2.25.1

2 years, 7 months

2
14
0 0

[PATCH] arm64: signal: Fix signal_sp() in compat64

by Kevin Brodsky

There are two issues with signal_sp() in compat64: 1. It uses regs->sp, which is not always the Executive SP. 2. It uses uaddr_to_user_ptr_safe(), which shouldn't be used to create user pointers in compat. The comment in signal_sp() also became meaningless, as it should refer to regs->sp and not regs->csp. Fix both issuses and expand the comment, as the situation is clearly complicated enough to warrant more explanations. Fixes: ("arm64: signal: Add support for 64-bit compat signal handling") Signed-off-by: Kevin Brodsky <kevin.brodsky(a)arm.com> --- arch/arm64/kernel/signal.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c index 80289e90fc66..183293d77f80 100644 --- a/arch/arm64/kernel/signal.c +++ b/arch/arm64/kernel/signal.c @@ -184,15 +184,25 @@ static user_uintptr_t signal_sp(struct pt_regs *regs) { #ifdef CONFIG_ARM64_MORELLO /* - * If the interrupted context was in Restricted, regs->csp is actually - * RCSP_EL0, which is usually what we want but not here, because signal - * handlers are always executed in Executive and therefore on the - * Executive stack. Read the actual (Executive) CSP_EL0 instead. + * Callers of this function want a valid user pointer to the stack. + * There are a number of situations to consider: + * - In PCuABI, CSP is expected to be a valid capability to access the + * stack, so we just return that. + * - In compat64, userspace uses only SP; we create a valid user pointer + * from SP using compat_ptr(). + * - In the standard ABI (PCuABI not selected), user pointers are still + * 64-bit integers so we just need to return SP. + * + * Signal handlers are always run in Executive. We therefore need to + * return a pointer to the Executive stack. As a result we cannot use + * regs->sp, as it is actually RSP_EL0 if the interrupted context was in + * Restricted. For this reason we use regs->csp even when we just want + * the (64-bit) SP. */ #ifndef SIGNAL_COMPAT64 return (user_uintptr_t)regs->csp; #else /* SIGNAL_COMPAT64 */ - return (user_uintptr_t)uaddr_to_user_ptr_safe(regs->sp); + return (user_uintptr_t)compat_ptr((ptraddr_t)regs->csp); #endif /* SIGNAL_COMPAT64 */ #else /* !CONFIG_ARM64_MORELLO */ return regs->sp; -- 2.38.1

2 years, 7 months

2
2
0 0

[PATCH] lib/cheri: Fix format string

by Kevin Brodsky

cheri_perms_t is a regular enum and therefore an int, not a long. GCC rightly complains that we are using %lx to print it; amend the format string accordingly. Fixes: ("linux/cheri.h: Introduce CHERI helpers") Signed-off-by: Kevin Brodsky <kevin.brodsky(a)arm.com> --- lib/cheri.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cheri.c b/lib/cheri.c index 3438718aa5db..c308a2c75559 100644 --- a/lib/cheri.c +++ b/lib/cheri.c @@ -25,7 +25,7 @@ build_user_cap(ptraddr_t addr, size_t len, cheri_perms_t perms, bool exact_bound ret = cheri_bounds_set(ret, len); WARN(perms & ~root_perms, - "Permission mask %#lx discarded while creating user capability %#lp\n", + "Permission mask %#x discarded while creating user capability %#lp\n", perms & ~root_perms, ret); WARN(cheri_is_invalid(ret), "Invalid user capability created: %#lp (%s bounds requested)\n", -- 2.38.1

2 years, 7 months

2
2
0 0

[PATCH 1/3] morello: Filesystem: Make fs labels with prefix MRLO- mounting

by carsten.haitzler＠foss.arm.com

From: Carsten Haitzler <carsten.haitzler(a)arm.com> Use fs labels for later mounting by label in fstab Signed-off-by: Carsten Haitzler <carsten.haitzler(a)arm.com> --- context/make_image.sh | 4 ++-- scripts/build-morello-image.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/context/make_image.sh b/context/make_image.sh index 964f287..b803bcd 100644 --- a/context/make_image.sh +++ b/context/make_image.sh @@ -30,7 +30,7 @@ mv /morello_sw/debian_bullseye/morello-pcuabi-env /morello_sw/stage2 dd if=/dev/zero of=morello-debian.img bs=1024K count=4096 __loop_device=$(losetup -f --show morello-debian.img) -mkfs.ext4 $__loop_device +mkfs.ext4 -L MRLO-ROOT $__loop_device mkdir mnt_point mount $__loop_device ./mnt_point @@ -52,7 +52,7 @@ cd $MORELLO_PCUABI_ENV dd if=/dev/zero of=morello-pcuabi-env.img bs=1024K count=100 __loop_device=$(losetup -f --show morello-pcuabi-env.img) -mkfs.ext4 $__loop_device +mkfs.ext4 -L MRLO-PCROOT $__loop_device mkdir mnt_point mount $__loop_device ./mnt_point diff --git a/scripts/build-morello-image.sh b/scripts/build-morello-image.sh index 31e021e..5b29a02 100755 --- a/scripts/build-morello-image.sh +++ b/scripts/build-morello-image.sh @@ -19,7 +19,7 @@ build_morello_image() { "$MORELLO_HOME/scripts/tools/mk-part-fat" \ -o "$MORELLO_GEN/bsp/$PLATFORM/morello.esp.img" \ -s "AUTO" \ - -l "ESP" \ + -l "MRLO-ESP" \ "$MORELLO_GEN/bsp/firmware/$PLATFORM/grub.efi" "/EFI/BOOT/BOOTAA64.EFI" \ "$MORELLO_GEN/bsp/firmware/$PLATFORM/grub_$PLATFORM.cfg" "/grub/grub.cfg" \ "$MORELLO_GEN/dts/arm/morello-$PLATFORM.dtb" "/morello.dtb" \ -- 2.25.1

2 years, 7 months

1
2
0 0

[PATCH v3 0/9] Support io_uring for Purecap apps

by Tudor Cretu

This series makes it possible for purecap apps to use the io_uring system. With these patches, all io_uring LTP tests pass in both Purecap and compat modes. Note that the LTP tests only address the basic functionality of the io_uring system and a significant portion of the multiplexed functionality is untested in LTP. I have finished investigating Purecap liburing tests and examples and the series is updated accordingly. I am investigating compat liburing tests at the moment, so another version might be expected. v3: - Introduce Patch 5 which exposes the compat handling logic for epoll_event. This is used then in io_uring/epoll.c. - Introduce Patch 6 which makes sure that when struct iovec is copied from userspace, the capability tags are preserved. - Fix a few sizeof(var) to sizeof(*var). - Use iovec_from_user so that compat handling logic is applied instead of copying directly from user - Add a few missing copy_from_user_with_ptr where suitable. v2: - Rebase on top of release 6.1 - Remove VM_READ_CAPS/VM_LOAD_CAPS patches as they are already merged - Update commit message in PATCH 1 - Add the generic changes PATCH 2 and PATCH 3 to avoid copying user pointers from/to userspace unnecesarily. These could be upstreamable. - Split "pulling the cqes memeber out" change into PATCH 4 - The changes for PATCH 5 and 6 are now split into their respective files after the rebase. - Format and change organization based on the feedback on the previous version, including creating helpers copy_*_from_* for various uAPI structs - Add comments related to handling of setup flags IORING_SETUP_SQE128 and IORING_SETUP_CQE32 - Add handling for new uAPI structs: io_uring_buf, io_uring_buf_ring, io_uring_buf_reg, io_uring_sync_cancel_reg. Gitlab issue: https://git.morello-project.org/morello/kernel/linux/-/issues/2 Review branch: https://git.morello-project.org/tudcre01/linux/-/commits/morello/io_uring_v3 Tudor Cretu (9): compiler_types: Add (u)intcap_t to native_words io_uring/rw : Restrict copy to only uiov->len from userspace io_uring/tctx: Copy only the offset field back to user io_uring: Pull cqes member out from rings struct epoll: Expose compat handling logic of epoll_event iov_iter: use copy_from_user_with_ptr for struct iovec io_uring: Implement compat versions of uAPI structs and handle them io_uring: Use user pointer type in the uAPI structs io_uring: Allow capability tag access on the shared memory fs/eventpoll.c | 39 ++-- include/linux/compiler_types.h | 7 + include/linux/eventpoll.h | 4 + include/linux/io_uring_types.h | 160 ++++++++++++++-- include/uapi/linux/io_uring.h | 62 ++++--- io_uring/advise.c | 2 +- io_uring/cancel.c | 40 +++- io_uring/cancel.h | 2 +- io_uring/epoll.c | 4 +- io_uring/fdinfo.c | 64 ++++++- io_uring/fs.c | 16 +- io_uring/io_uring.c | 329 +++++++++++++++++++++++++-------- io_uring/io_uring.h | 126 ++++++++++--- io_uring/kbuf.c | 119 ++++++++++-- io_uring/kbuf.h | 8 +- io_uring/msg_ring.c | 4 +- io_uring/net.c | 25 +-- io_uring/openclose.c | 4 +- io_uring/poll.c | 4 +- io_uring/rsrc.c | 150 ++++++++++++--- io_uring/rw.c | 17 +- io_uring/statx.c | 4 +- io_uring/tctx.c | 57 +++++- io_uring/timeout.c | 10 +- io_uring/uring_cmd.c | 5 + io_uring/uring_cmd.h | 7 + io_uring/xattr.c | 12 +- lib/iov_iter.c | 2 +- 28 files changed, 1014 insertions(+), 269 deletions(-) -- 2.34.1

2 years, 7 months

2
19
0 0

[PATCH v3 0/3] kselftest: Gcc fixes for clone test

by Amit Daniel Kachhap

Hi, These 3 patch fixes the failure in clone test with Gcc toolchain. They need the recent v4 version of Gcc support patches posted earlier [1]. The full patch series can be found here [2]. Changes in v3: * Patch 1 updated for for appropriate variable name. * Patch 2 newly added to add and use waitpid() in several places. * Patch 3 updated for cleanups. * Commit log updated. [1]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_support_v4 [2]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_clone_fixes_v3 Thanks, Amit Daniel Amit Daniel Kachhap (2): Amit Daniel Kachhap (3): kselftests/arm64: morello: Fix restricted mode tests with Gcc kselftests/arm64: morello: Add a waitpid() syscall kselftests/arm64: morello: clone: Remove loop check tools/testing/selftests/arm64/morello/clone.c | 42 +++++++++++-------- .../selftests/arm64/morello/freestanding.h | 5 +++ .../testing/selftests/arm64/morello/signal.c | 16 +++---- 3 files changed, 38 insertions(+), 25 deletions(-) -- 2.25.1

2 years, 7 months

2
5
0 0

[PATCH 0/2] kselftest: Gcc fixes for clone test

by Amit Daniel Kachhap

Hi, These 2 patch fixes the failure in clone test with Gcc toolchain. They need the recent v4 version of Gcc support patches posted earlier [1]. The full patch series can be found here [2]. [1]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_support_v4 [2]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_clone_fixes_v1 Thanks, Amit Daniel Amit Daniel Kachhap (2): kselftests/arm64: morello: Fix restricted mode tests with Gcc kselftests/arm64: morello: clone: Remove loop check tools/testing/selftests/arm64/morello/clone.c | 19 +++++++------------ .../selftests/arm64/morello/freestanding.h | 8 ++++++++ .../arm64/morello/freestanding_start.S | 18 ++++++++++++++++++ 3 files changed, 33 insertions(+), 12 deletions(-) -- 2.25.1

2 years, 7 months

3
11
0 0

[PATCH v2 0/2] kselftest: Gcc fixes for clone test

by Amit Daniel Kachhap

Hi, These 2 patch fixes the failure in clone test with Gcc toolchain. They need the recent v4 version of Gcc support patches posted earlier [1]. The full patch series can be found here [2]. Changes in v2: * Patch 1 is modified to calculate function pointer branch address from PCC. * Commit log updated. [1]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_support_v4 [2]: git@git.morello-project.org:amitdaniel/linux.git gcc_kselftests_clone_fixes_v2 Thanks, Amit Daniel Amit Daniel Kachhap (2): kselftests/arm64: morello: Fix restricted mode tests with Gcc kselftests/arm64: morello: clone: Remove loop check tools/testing/selftests/arm64/morello/clone.c | 30 +++++++++++-------- .../selftests/arm64/morello/freestanding.h | 8 +++++ 2 files changed, 26 insertions(+), 12 deletions(-) -- 2.25.1

2 years, 7 months

2
3
0 0

[PATCH] NFSv4: Fix nfs4_proc_setlease definition

by Luca Vizzarro

The definition in the implementation of nfs4_proc_setlease was originally changed without updating the definition in the header file. Fixes: ("fs: Pass argument to fcntl_setlease as int") Signed-off-by: Luca Vizzarro <Luca.Vizzarro(a)arm.com> --- Sending in a fix for a bug that was merged and was undetected by the build script and the CI. Credit goes to Beata for detecting this. Luca fs/nfs/nfs4_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index cfef738d765e..0f9bb0f2f6c5 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h @@ -326,7 +326,7 @@ extern int update_open_stateid(struct nfs4_state *state, const nfs4_stateid *open_stateid, const nfs4_stateid *deleg_stateid, fmode_t fmode); -extern int nfs4_proc_setlease(struct file *file, long arg, +extern int nfs4_proc_setlease(struct file *file, int arg, struct file_lock **lease, void **priv); extern int nfs4_proc_get_lease_time(struct nfs_client *clp, struct nfs_fsinfo *fsinfo); -- 2.34.1

2 years, 8 months

3
5
0 0

2025

2024

2023

2022

linux-morello